feat(projectSecrets): add CRUDL for project secrets #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 31, 2024 13:08
Signed-off-by: Lukáš Janeček <[email protected]>
Signed-off-by: Lukáš Janeček <[email protected]>
Signed-off-by: Lukáš Janeček <[email protected]>
pilartomas
reviewed
Jan 20, 2025
| import { createPaginatedResponse, getListCursor } from '@/utils/pagination.js'; | ||
| import { getUpdatedValue } from '@/utils/update.js'; | ||
|
|
||
| export function toDto(toolSecret: Loaded<ToolSecret, 'tool'>): ToolSecretDto { |
Comment on lines
+32
to
+34
| value: { | ||
| type: 'string' | ||
| }, |
There was a problem hiding this comment.
Are we sure about this? Should user (and the rest of the project) be able to read the value?
| value: { | ||
| type: 'string' | ||
| }, | ||
| tool: toolSchema |
There was a problem hiding this comment.
I don't think tool should be included in the tool secret response. If special endpoint for UI is needed, I'd rather go that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE