Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE-102 Scrollable and Code Vault #134

Merged
merged 2 commits into from
Jan 8, 2021
Merged

FE-102 Scrollable and Code Vault #134

merged 2 commits into from
Jan 8, 2021

Conversation

tomproberts
Copy link
Contributor

Refactored out a Scrollable component which is used in every one of the Tab implementations. Both sides of CodeVault now scroll independently.

lancelotblanchard
lancelotblanchard approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@lancelotblanchard lancelotblanchard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I might be in favour of having the "Delete" and "Edit" buttons stick to the bottom of the Functions Tab when the content does not fill the whole space, but that's a minor thing.

@tomproberts tomproberts merged commit 19c02e1 into master Jan 8, 2021
@tomproberts tomproberts deleted the scrollable branch January 8, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancelotblanchard lancelotblanchard lancelotblanchard approved these changes

@gidonkatten gidonkatten Awaiting requested review from gidonkatten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomproberts @lancelotblanchard