Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCubV1*: fix alignment of the depth #188

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Nov 8, 2023

It is now aligned w/ the RGB frame as on the real robot.
It fixes #183

cc @xEnVrE

It is now aligned w/ the RGB frame as on the real robot.
It fixes #183
@Nicogene Nicogene requested a review from traversaro November 8, 2023 16:46
@Nicogene Nicogene self-assigned this Nov 8, 2023
@Nicogene Nicogene changed the title ergoCubV1*: fix alignment of the depth. ergoCubV1*: fix alignment of the depth Nov 8, 2023
@xEnVrE
Copy link
Contributor

xEnVrE commented Nov 8, 2023

@Nicogene
I saw you have changed the field of view. Would it be possible to verify whether the file

https://github.com/icub-tech-iit/ergocub-software/blob/master/urdf/ergoCub/conf/sensors/gazebo_ergocub_rgbd_camera.ini

is actually used by Gazebo or it is an old one? Because otherwise, given that you have changed the field of view, the intrinsics should change as well, what do you think - assuming that the current value was correct with respect to the previous value of the field of view ?

focalLengthX 570.3422241210938
focalLengthY 570.3422241210938

@Nicogene
Copy link
Member Author

Nicogene commented Nov 9, 2023

@Nicogene I saw you have changed the field of view. Would it be possible to verify whether the file

master/urdf/ergoCub/conf/sensors/gazebo_ergocub_rgbd_camera.ini

is actually used by Gazebo or it is an old one? Because otherwise, given that you have changed the field of view, the intrinsics should change as well, what do you think - assuming that the current value was correct with respect to the previous value of the field of view ?

focalLengthX 570.3422241210938
focalLengthY 570.3422241210938

Probably yes, I don't know if those values are correct or not, it seems not, I think they have been copy-pasted from iCub3.
Probably we should ask them to the device via rpc and put those, what do you think @xEnVrE ?

@Nicogene
Copy link
Member Author

Nicogene commented Nov 9, 2023

I checked on the D450 we have spare and I updated the focal length also in the ini file:

@Nicogene Nicogene merged commit 91dfd1a into master Nov 9, 2023
3 checks passed
@Nicogene Nicogene deleted the fix/depthAlignment branch November 9, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss RealSense rgb / depth frames and alignment in simulation
3 participants