Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ValidationUtils for ThermalGrids #1118

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Use ValidationUtils for ThermalGrids #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
831e3a3
Use ValidationUtils for ThermalGrids
danielfeismann Jan 22, 2025
ef6958b
spotless
danielfeismann Jan 22, 2025
ae854dc
use ValidationUtils not ThermalValidationUtils
danielfeismann Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Introduce ThermalDemandWrapper [#1049](https://github.com/ie3-institute/simona/issues/1049)
- Added Marius Staudt to list of reviewers [#1057](https://github.com/ie3-institute/simona/issues/1057)
- Throw exception if the slack node is not directly conected to a transformer. [#525](https://github.com/ie3-institute/simona/issues/525)
- Use ValidationUtils for ThermalGrids [#1117](https://github.com/ie3-institute/simona/issues/1117)

### Changed
- Adapted to changed data source in PSDM [#435](https://github.com/ie3-institute/simona/issues/435)
Expand Down
2 changes: 2 additions & 0 deletions src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import edu.ie3.datamodel.models.result.system.{
HpResult,
SystemParticipantResult,
}
import edu.ie3.datamodel.utils.validation.ValidationUtils
import edu.ie3.simona.agent.ValueStore
import edu.ie3.simona.agent.participant.ParticipantAgent.getAndCheckNodalVoltage
import edu.ie3.simona.agent.participant.ParticipantAgentFundamentals
Expand Down Expand Up @@ -456,6 +457,7 @@ trait HpAgentFundamentals
s"Unable to initialize heat pump agent '${inputModel.electricalInputModel.getUuid}' without thermal grid model."
)
case WithHeatInputContainer(_, thermalGrid) =>
ValidationUtils.check(thermalGrid)
/* Build the actual heat pump model */
HpModel(
inputModel.electricalInputModel,
Expand Down
Loading