Sbachmei/mic 5755/improve supported py version handling #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
force-pushed
the
sbachmei/mic-5755/improve-supported-py-version-handling
branch
from
7a4098d to
e88d6c3
Compare
stevebachmeier
requested review from
aflaxman,
albrja,
hussain-jafari,
patricktnast,
rmudambi and
zmbc
as code owners
stevebachmeier
commented
Jan 6, 2025
README.rst
Outdated
| @@ -7,7 +7,7 @@ entity resolution (ER) pipelines. | |||
|
|
|||
| .. _python_support: | |||
|
|
|||
| **Supported Python versions: 3.11, 3.12** | |||
| **Supported Python versions: 3.1, 3.2** | |||
There was a problem hiding this comment.
Did this to test that the update-readme action kicks off and changes these back automatically
hussain-jafari
approved these changes
Jan 6, 2025
stevebachmeier
commented
Jan 6, 2025
| @@ -7,7 +7,7 @@ entity resolution (ER) pipelines. | |||
|
|
|||
| .. _python_support: | |||
|
|
|||
| **Supported Python versions: 3.1, 3.2** | |||
| **Supported Python versions: 3.11, 3.12** | |||
There was a problem hiding this comment.
Got changed to match the python_versions.json ✅
rmudambi
approved these changes
Jan 7, 2025
stevebachmeier
deleted the
sbachmei/mic-5755/improve-supported-py-version-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handle supported python versions
Description
Changes and notes
I got annoyed with always having the wrong py version installedsince easylink is different than the rest of our framework repos. So the
primary goal was to add the py version check during setup, but then it
was easy enough to copy lct and just do all the things.
Verification and Testing