Remove Mutable State Bug #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricktnast
requested review from
albrja,
collijk,
hussain-jafari,
rmudambi and
stevebachmeier
as code owners
rmudambi
approved these changes
Nov 28, 2024
| @@ -191,9 +191,9 @@ def format_call_data(call_data, parameters): | |||
| "If providing call_data as a series it must " | |||
| "be indexed consistently with the parameter data." | |||
| ) | |||
| call_data = pd.Series(call_data, index=parameters.index) | |||
| call_data = pd.Series(call_data, index=parameters.index, copy=True) | |||
albrja
approved these changes
Dec 2, 2024
| @pytest.mark.parametrize("distribution", distributions) | ||
| def test_cdf(test_data, distribution): | ||
| mean, sd, test_q = test_data | ||
| test_distribution = distribution(mean=mean, sd=sd) | ||
| x_min, x_max = test_distribution.parameters.x_min, test_distribution.parameters.x_max | ||
|
|
||
| # TODO MIC-5595: Find and fix places where inputs are mutated in-place | ||
| test_x = test_distribution.ppf(test_q.copy()) | ||
| test_x = test_distribution.ppf(test_q) |
There was a problem hiding this comment.
Can we delete the #TODO right above this line then?
| @pytest.mark.parametrize("distribution", distributions) | ||
| @pytest.mark.parametrize("mean, sd", parameters) | ||
| @pytest.mark.parametrize("test_q", test_qs) | ||
| def test_no_state_mutations(mean, sd, test_q, distribution): |
There was a problem hiding this comment.
And this test failed prior to your fix?
stevebachmeier
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Mutable State Bug
Description
Changes and notes
Risk Distributions had a bug where you could mutate the state of an underlying pandas series, so it would hide issues when you used that same input series as a check against some output. I added copy=True to the
format_call_datamethod informatting.py, then went ahead and just added copy=True to all series / dataframe instantiations informatting.pyjust to be safe.Testing
Added tests first, verified they failed, then verified they now pass.