Mic-4617/Drop support for 3.8 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrja
requested review from
collijk,
hussain-jafari,
mattkappel,
patricktnast,
rmudambi and
stevebachmeier
as code owners
patricktnast
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
I would suggest removing the reference to python 3.8 in the doc config as well:
vivarium_inputs/docs/source/conf.py
Line 196 in 70c7a6d
hussain-jafari
approved these changes
Oct 16, 2023
stevebachmeier
approved these changes
Oct 16, 2023
rmudambi
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mic-4617/Drop support for 3.8
Drop support for python 3.8
Changes and notes
-drops support for python 3.8
Testing
Will check schedule workflow runs successfully.