-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCS and DAC updates #266
CCS and DAC updates #266
Conversation
This values were for DAC with storage, but the technology is no longer included as DAC's variants list
@ywpratama it likes also leakage assumptions have changed? I see that |
Also, if I look at the input/output flows, it seems The below is how the flow has been described previously, and to the best of my knowledge, that is not how it is implemented here: |
Hi Matt, the assumption is still the same. I just switched "value" and "commodity scale" so it will be more consistent with other techs. |
Ah, yes, true. For some reason we used to have "exports" as output for co2 storage. If I remember correctly someone (I forgot who) said it was to track and see if co2 storage actually does some activity. So I wanted to keep it, just in case. I remember now Oliver also questioned this at some point. So, if we don't need it anymore, we can remove it. At the moment co2 "useful" is just floating around doing nothing in the model. CO2 trans output is at level final, which can feed into storage or util. |
If there is no connection, we can still keep it in the model, but we need to make sure that it cant be used as a free alternative to he storage. You could put a temporary bound_activity_up of 0 on it for example; or comment it out in the yaml file so it just doesnt get generated. A quick fix is acceptable, but we shouldnt forget to refine this later on for e-fuels in the industry/materials sector. |
Thanks, Oliver. There is no connection there. No technology has useful co2 as input. And for materials, it is specifically use "captured_co2", aggregated by "co2_util". I tested it in some scenarios where methanol production uses captured_co2 and it worked fine. For the fix I can just remove it from co2 storage output in the yaml file if that's what we agree to do. |
sounds fine to me. |
@macflo8, @OFR-IIASA, @gidden, thanks for all the comments. CO2 useful is now removed from the output. @gidden, for the "hardcoded" values issue, I am afraid it requires a bit of changes in the "add_tech" function. I know what to changes, but I cannot test it at the moment as I am outside IIASA network. So, perhaps should not take the risk of making the function not working properly at this stage? Happy to implement once I am back |
Yes, definitely not blocking, that's why we made an issue - so we remember for the future =). Thanks @ywpratama ! |
@@ -371,27 +371,27 @@ def add_ccs_setup(scen: message_ix.Scenario, ssp="SSP2"): | |||
ccs_ssp_pars = { | |||
"LED": { | |||
"co2storage": 0.25, | |||
"co2rate": 4000 / 3.667, | |||
"co2rate": 6000 / 3.667, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future reference, these are the lines that define the ssp assumptions of injection limits and storage limits. see issue #267
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted! Thanks!
This PR has 2 updates:
How to review
Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.
PR checklist