Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address failing pytest #565

Closed
wants to merge 2 commits into from
Closed

Address failing pytest #565

wants to merge 2 commits into from

Conversation

LauWien
Copy link
Contributor

@LauWien LauWien commented Feb 22, 2022

This PR addresses the failing _pytest.yam_l. It tries out if the test_add_year.py is still failing using the new pandas release v1.4.1.

Update: the tests in test_add_year.py succeed. Tests in test_tutorials.py are failing in

  • every OS with Python version 3.6,
  • Python version 3.8 and 3.9 for ubuntu-latest
    For macOS latest and Windows latest all tests are successful on Python version 3.8 and 3.9. Please see here.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅

@LauWien LauWien self-assigned this Feb 22, 2022
@LauWien LauWien marked this pull request as draft February 22, 2022 10:23
@LauWien LauWien changed the title Upgrade pandas Address failing pytest Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #565 (6c3ef88) into main (1df3619) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #565     +/-   ##
=======================================
- Coverage   93.8%   93.7%   -0.1%     
=======================================
  Files         40      40             
  Lines       3057    3057             
=======================================
- Hits        2870    2867      -3     
- Misses       187     190      +3     
Impacted Files Coverage Δ
message_ix/tests/test_tutorials.py 88.4% <0.0%> (-11.6%) ⬇️

@LauWien LauWien added this to the 3.5 milestone Feb 22, 2022
@LauWien
Copy link
Contributor Author

LauWien commented Feb 23, 2022

Supersede by #557. See also conversations in #566.

@LauWien LauWien closed this Feb 23, 2022
@LauWien LauWien linked an issue Feb 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError in .add_year.interpolate_2d() with pandas 1.4.0
1 participant