IPv6 canonicalization failures #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- :: must not be used to shorten just one 16-bit 0 field - same-length sequence of 0 fields in initial position is not shortened
ato
added a commit
that referenced
this pull request
Nov 22, 2024
|
Oops. Thanks. I've added these in and replaced my broken version with Guava's implementation. I should have just done that in the first place. At first glance I'd thought it looked too dependent on the rest of Guava to easily extract but it actually wasn't too bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the unit test. Examples taken from Guava InetAddressesTest.java, line 329