Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi platform support #28

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Add multi platform support #28

merged 6 commits into from
Jul 8, 2024

Conversation

OliverStolzBO
Copy link
Collaborator

Rework code that did only work for the Linux operating system to support macOS and Windows as well.

- the browserify task depends on the code that is generated by npm watch
- Shell commands for deleting / creating a directory are OS dependent
- Therefore, remove the commands and consistently keep the media dir
@OliverStolzBO OliverStolzBO requested a review from maxhoerstr July 8, 2024 14:11
@OliverStolzBO OliverStolzBO force-pushed the multi-platform-support branch from f218761 to 2759ab3 Compare July 8, 2024 14:24
Copy link
Collaborator

@maxhoerstr maxhoerstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@maxhoerstr maxhoerstr merged commit 3374a60 into main Jul 8, 2024
3 checks passed
@maxhoerstr maxhoerstr deleted the multi-platform-support branch July 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants