chore(server): avoid copying sources in dev #12794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dev target to the web and server Dockerfiles, and change docker-compose.dev.yml to use the dev target. The dev target avoids copying files so that the docker image is smaller.
jrasm91
reviewed
Sep 19, 2024
docker/docker-compose.dev.yml
Outdated
| @@ -55,6 +55,7 @@ services: | |||
| image: immich-web-dev:latest | |||
| build: | |||
| context: ../web | |||
| target: dev | |||
There was a problem hiding this comment.
the web Dockerfile is only ever used for development so you can revert related changes.
There was a problem hiding this comment.
Sorry for taking so long. I have removed the target: dev and removed the COPY from the web/Dockerfile completely so that it can only be used with the source volume.
|
Hello, any update on this PR? |
web/Dockerfile is only used by docker-compose.dev.yml so a dev target is redundant. Instead, just remove the copy
|
Hey @yonran, is this ready to be reviewed and merged? Changes look simple, if they're good from your end I can give this a quick test and merge it in. |
Yes please |
jrasm91
approved these changes
Jan 14, 2025
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
* chore(server): avoid copying sources in dev Add a dev target to the web and server Dockerfiles, and change docker-compose.dev.yml to use the dev target. The dev target avoids copying files so that the docker image is smaller. * chore: respond to PR: don't add dev target web/Dockerfile is only used by docker-compose.dev.yml so a dev target is redundant. Instead, just remove the copy --------- Co-authored-by: Jason Rasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dev target to the web and server Dockerfiles, and change docker-compose.dev.yml to use the dev target. The dev target avoids copying files so that the docker image is smaller.
My motivation was that when I tried using docker-compose.dev.yml, I kept running out of disk space because docker would create big docker containers with copies of the application code even though they weren’t being used.