Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): immich-ui components #14263

Merged
merged 5 commits into from
Jan 14, 2025
Merged

feat(web): immich-ui components #14263

merged 5 commits into from
Jan 14, 2025

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Nov 20, 2024 •
edited
Loading

Light Dark
image image
image image
image image
image image
image image

@jrasm91 jrasm91 force-pushed the feat/immich-ui branch 2 times, most recently from f6c8c7b to f33a77c Compare November 20, 2024 20:16
@jrasm91 jrasm91 force-pushed the feat/immich-ui branch 4 times, most recently from ffa3d9c to 865e5ed Compare January 14, 2025 15:34
@jrasm91 jrasm91 marked this pull request as ready for review January 14, 2025 15:47
@alextran1502
Copy link
Contributor

alextran1502 commented Jan 14, 2025 •
edited
Loading

Can you write some documentation on how we can develop/modify the UI library simultaneously with the web project?

@jrasm91 jrasm91 requested a review from bo0tzz as a code owner January 14, 2025 18:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 14, 2025
danieldietzler
danieldietzler approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasm91 jrasm91 merged commit b9000d8 into main Jan 14, 2025
36 checks passed
@jrasm91 jrasm91 deleted the feat/immich-ui branch January 14, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

@bo0tzz bo0tzz Awaiting requested review from bo0tzz bo0tzz is a code owner

Assignees
No one assigned
Labels
changelog:feature documentation Improvements or additions to documentation 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasm91 @alextran1502 @danieldietzler