feat(web): Slideshow is enabled everywhere. It no longer needs assetStore. #15077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matitalatina
changed the title
matitalatina
force-pushed
the
web-slideshow-everywhere
branch
from
2c27408 to
67508be
Compare
matitalatina
force-pushed
the
web-slideshow-everywhere
branch
from
67508be to
3a72e14
Compare
matitalatina
changed the title
matitalatina
force-pushed
the
web-slideshow-everywhere
branch
2 times, most recently
from
e2f8c5d to
3ba62e7
Compare
alextran1502
reviewed
Jan 4, 2025
web/src/lib/components/utilities-page/duplicates/duplicates-compare-control.svelte
Outdated
Show resolved
Hide resolved
matitalatina
force-pushed
the
web-slideshow-everywhere
branch
6 times, most recently
from
b95ec73 to
8afd324
Compare
matitalatina
force-pushed
the
web-slideshow-everywhere
branch
from
8afd324 to
ad666a8
Compare
matitalatina
force-pushed
the
web-slideshow-everywhere
branch
from
ad666a8 to
9460ec5
Compare
jrasm91
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I enabled the slideshow on every page. Slideshow doesn't require assetStore to work anymore.
Screenshot
Here's the slideshow inside smart search page.
How I tested
Started slideshow on every page, changing the order (forward, backward, shuffle).
Known bugs
The slideshow, in smart search for example, shows only the assets loaded. It doesn't show the assets not loaded yet.
This can be achieved by implementing
onPrevious,onNext,onRandomGalleryViewer's methods in the search page.But I think this PR is a good step forward and this enhancement can be done in a later stage.
By the way, the bug is already present if you keep swiping on next asset in the assetViewer.
Disclaimer
This is my first PR for this amazing project. Please let me know if I did something wrong or you see something to improve. Feel free to edit / change it.