Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): render whitespaces in file names and paths on photos and folders pages correctly #15266

Merged

Conversation

fholzer
Copy link
Contributor

@fholzer fholzer commented Jan 11, 2025

Not sure if you're interested in this change. In case you are, this fixes #15265

Asset Details view

Before:
image

After:
image

Folder view

Before:
image

After:
image

Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanting whitespace in filenames like this is frankly cursed, but the fix is harmless.

@fholzer
Copy link
Contributor Author

fholzer commented Jan 11, 2025

I won't disagree 🙈 Though for a subset of my photos I have an interest in keeping file and folder names as they are, because I sync those from friends. Want to be in a position where i can run rsync and only get new files next time i sync them. When I tried to copy and use the file location for one of those photos a couple days back... it took me a couple of minutes to figure out what was wrong hehe

@alextran1502 alextran1502 merged commit 77d4eb8 into immich-app:main Jan 12, 2025
34 of 35 checks passed
@fholzer fholzer deleted the fix/web-whitespaces-in-file-paths branch January 12, 2025 09:20
yosit pushed a commit to yosit/immich that referenced this pull request Jan 13, 2025
arctic-foxtato pushed a commit to arctic-foxtato/immich that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web incorrectly reders whitespaces in file names and paths
3 participants