refactor: migrate audit repository to kysely #15269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
commented
Jan 11, 2025
| @@ -20,7 +20,7 @@ export class VersionHistoryRepository implements IVersionHistoryRepository { | |||
| return this.db.selectFrom('version_history').selectAll().orderBy('createdAt', 'desc').executeTakeFirst(); | |||
| } | |||
|
|
|||
| @GenerateSql({ params: [DummyValue.STRING] }) | |||
| @GenerateSql({ params: [{ version: DummyValue.STRING }] }) | |||
There was a problem hiding this comment.
Noticed this was broken when generating SQL 😅
There was a problem hiding this comment.
Lol that explains why it was missing. Why doesn't it error on that?
There was a problem hiding this comment.
some queries throw an error. like when you try to insert a fake uuid into the album_assets intersection table. when you run make sql it logs these errors, and there was one for this query.
mertalev
reviewed
Jan 11, 2025
mertalev
approved these changes
Jan 13, 2025
jrasm91
approved these changes
Jan 14, 2025
jrasm91
force-pushed
the
refactor/kysely-audit
branch
from
2dddd7a to
e401d72
Compare
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.