Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate user repository to kysely #15296

Merged
merged 15 commits into from
Jan 14, 2025
Merged

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Jan 13, 2025

No description provided.

server/src/queries/user.repository.sql Outdated Show resolved Hide resolved
server/src/repositories/user.repository.ts Outdated Show resolved Hide resolved
server/src/repositories/user.repository.ts Outdated Show resolved Hide resolved
@jrasm91 jrasm91 force-pushed the refactor-user-repo-to-kysely branch from 34898de to e4a3352 Compare January 13, 2025 21:32
server/src/repositories/user.repository.ts Outdated Show resolved Hide resolved
server/src/repositories/user.repository.ts Outdated Show resolved Hide resolved
server/src/repositories/user.repository.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

server/src/repositories/user.repository.ts Outdated Show resolved Hide resolved
@jrasm91 jrasm91 merged commit 3da7501 into main Jan 14, 2025
36 checks passed
@jrasm91 jrasm91 deleted the refactor-user-repo-to-kysely branch January 14, 2025 01:30
arctic-foxtato pushed a commit to arctic-foxtato/immich that referenced this pull request Jan 14, 2025
* refactor: migrate user repository to kysely

* refactor: migrate user repository to kysely

* refactor: migrate user repository to kysely

* refactor: migrate user repository to kysely

* fix: test

* clean up

* fix: metadata retrieval bug

* use correct typeing for upsert metadata

* pr feedback

* pr feedback

* fix: add deletedAt check

* fix: get non deleted user by default

* remove console.log

* fix: stop kysely after command finishes

* final clean up

---------

Co-authored-by: Jason Rasmussen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants