feat: Allow multiple ML models to be preloaded #15418
Merged
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
mertalev
reviewed
Jan 19, 2025
machine-learning/app/main.py
Outdated
| @@ -77,29 +77,31 @@ async def lifespan(_: FastAPI) -> AsyncGenerator[None, None]: | |||
| async def preload_models(preload: PreloadModelData) -> None: | |||
| log.info(f"Preloading models: clip:{preload.clip} facial_recognition:{preload.facial_recognition}") | |||
|
|
|||
| async def load_models(model_string: str, model_type: "ModelType", model_task: "ModelTask") -> None: | |||
There was a problem hiding this comment.
For some reason I thought they were required.
Quotes have been removed, however I have not tested this latest version yet as I've made changes on mobile.
There was a problem hiding this comment.
Found time to run it locally. It seems to load models as desired
Co-authored-by: Mert <[email protected]>
mertalev
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a comma separated values in ML preload environment variables