Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added table workflow #8

Merged
merged 4 commits into from
Aug 9, 2024
Merged

added table workflow #8

merged 4 commits into from
Aug 9, 2024

Conversation

larsbuntemeyer
Copy link
Contributor

Added a workflow file that will create cmor tables in this repository using data-request-tools. The tables are create from data-request-fpsurbrcc.csv , i am not sure, if that's the right one? Or should we use a combination of all tables?

@larsbuntemeyer larsbuntemeyer requested a review from jesusff August 8, 2024 15:30
@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review August 8, 2024 15:30
@larsbuntemeyer
Copy link
Contributor Author

larsbuntemeyer commented Aug 8, 2024

Is it ok, if the tables goe into this repo? i would add a pr action, if the data request changes to update cmor tables accordingly...

@larsbuntemeyer larsbuntemeyer marked this pull request as draft August 8, 2024 15:33
Copy link
Member

@jesusff jesusff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

It is fine if the tables go into a folder in this same directory. We should read from the merged table, though. It is available under docs/data-request-i4c-merged.csv

@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review August 9, 2024 11:59
@larsbuntemeyer larsbuntemeyer merged commit 5fb91fb into main Aug 9, 2024
@larsbuntemeyer larsbuntemeyer deleted the cmor-tables branch August 9, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants