-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spec): consensus spec, from paper, general overview #389
Conversation
Co-authored-by: Josef Widder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I left some comments. Some just came out of the live discussion we had this morning, and it might be good to just mention these points within the todos.
specs/consensus/README.md
Outdated
`⟨PRECOMMIT, h, r, *⟩` messages for values that are not in line with the | ||
expected contents of its `lockedValue_q` and `lockedRound_q` variables. | ||
|
||
It is virtually impossible to prevent **equivocation attacks**, and the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what you want to say here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot prevent a process from equivocating, except if we use some HSM solutions or complex protocol to ensure that there a single copy of each message (sender, step, round, height) in the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase this.
Co-authored-by: Josef Widder <[email protected]>
Part of #397.
Rendered.
There are still lots of TODOs and links to be made, added to the existing consensus spec, from which I am removing the duplicated redundant parts.
When reviewing, please suggest missing points to be addressed in the next iteration. Recall, however, that this document refers to the pseudo-code, the abstract consensus algorithm.
PR author checklist