chore(code): Add "full" proposal logic in consensus but outside the driver #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for the new keeper.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 83.96% 84.82% +0.86%
==========================================
Files 88 89 +1
Lines 6283 6487 +204
==========================================
+ Hits 5275 5502 +227
+ Misses 1008 985 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 tasks
romac
reviewed
Sep 25, 2024
Clean the full proposals when decided.
…ProposalOnly` (#421)
romac
reviewed
Sep 25, 2024
|
@romac , added L28 handling, please take a look. |
|
will clean up tests and add more |
Remove proposal for ALL rounds on decide. Keep the last two heights. Push proposed value for higher heights in the msg_queue. Add full_proposals_for_value to return multiple proposals after value add. Refactor tests. Add more POL tests.
|
@romac, as discussed I added the case where the value is received after the proposal(s). Added tests. |
romac
approved these changes
Sep 30, 2024
romac
added a commit
that referenced
this pull request
Sep 30, 2024
…river (#417) * Implement the complete proposal logic * Add tests for the new keeper. * Handle L28 * Remove proposals for all rounds on decide. Keep the last two heights. --------- Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #416
PR author checklist