Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): Restream values for which we have seen a polka in a previous round #506

Merged
merged 17 commits into from
Nov 5, 2024

Conversation

ancazamfir
Copy link
Collaborator

Closes: #405


PR author checklist

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.50%. Comparing base (a94bbb4) to head (0b107ac).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a94bbb4) and HEAD (0b107ac). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a94bbb4) HEAD (0b107ac)
integration 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #506       +/-   ##
===========================================
- Coverage   84.45%   46.50%   -37.95%     
===========================================
  Files         126       39       -87     
  Lines        9329     1800     -7529     
===========================================
- Hits         7878      837     -7041     
+ Misses       1451      963      -488     
Flag Coverage Δ
integration ?
mbt 46.50% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ancazamfir ancazamfir marked this pull request as ready for review November 5, 2024 10:53
@ancazamfir ancazamfir requested a review from romac November 5, 2024 10:54
@ancazamfir ancazamfir merged commit 51cb551 into main Nov 5, 2024
24 of 25 checks passed
@ancazamfir ancazamfir deleted the anca/restream branch November 5, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Stream the block when re-proposing (L16)
2 participants