Skip to content

Commit

Permalink
Add chart value to customize deployment rollout strategy (#9)
Browse files Browse the repository at this point in the history
Signed-off-by: Sanket Sudake <[email protected]>
  • Loading branch information
sanketsudake authored Jul 15, 2024
1 parent a4eabb8 commit ad49683
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/text-embeddings-inference/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.1.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions charts/text-embeddings-inference/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ metadata:
spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
strategy:
{{- toYaml .Values.strategy | nindent 4 }}
{{- end }}
selector:
matchLabels:
Expand Down
6 changes: 6 additions & 0 deletions charts/text-embeddings-inference/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ replicaCount: 1

kind: Deployment

strategy: {}
# rollingUpdate:
# maxSurge: 1
# maxUnavailable: 1
# type: RollingUpdate

image:
repository: ghcr.io/huggingface/text-embeddings-inference
pullPolicy: IfNotPresent
Expand Down
2 changes: 1 addition & 1 deletion charts/text-generation-inference/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.1.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions charts/text-generation-inference/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ metadata:
spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
strategy:
{{- toYaml .Values.strategy | nindent 4 }}
{{- end }}
selector:
matchLabels:
Expand Down
6 changes: 6 additions & 0 deletions charts/text-generation-inference/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ replicaCount: 1

kind: Deployment

strategy: {}
# rollingUpdate:
# maxSurge: 1
# maxUnavailable: 1
# type: RollingUpdate

image:
repository: ghcr.io/huggingface/text-generation-inference
pullPolicy: IfNotPresent
Expand Down

0 comments on commit ad49683

Please sign in to comment.