fix: edge case of Safari

inpageedit · Jan 4, 2024 · 1b191dd · 1b191dd
1 parent a365b31
commit 1b191dd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/module/loadQuickDiff.js b/src/module/loadQuickDiff.js
@@ -3,7 +3,7 @@ import { _analytics } from './_analytics'
 import { quickDiff } from './quickDiff'
 import { quickEdit } from './quickEdit'
 import { mwConfig } from '../utils/mw'
-import { isAlternativeClick } from '../utils/alternativeClick'
+import { isPureLMBClick } from '../utils/mouseEvent'
 const { getParamValue } = mw.util
 
 function injectLinks(container) {
@@ -88,7 +88,7 @@ function injectLinks(container) {
 
       // 点击事件
       $this.on('click', function (e) {
-        if (isAlternativeClick(e)) return
+        if (!isPureLMBClick(e)) return
         e.preventDefault()
         _analytics('quick_diff_recentchanges')
         return quickDiff(params)
@@ -110,7 +110,7 @@ export function loadQuickDiff(container) {
       $('<button>')
         .text(_msg('quick-diff'))
         .on('click', function (e) {
-          if (isAlternativeClick(e)) return
+          if (!isPureLMBClick(e)) return
 
           e.preventDefault()
           _analytics('quick_diff_history_page')

diff --git a/src/utils/alternativeClick.js → src/utils/mouseEvent.js b/src/utils/alternativeClick.js → src/utils/mouseEvent.js
@@ -6,3 +6,12 @@ export const isAlternativeClick = (e) => {
   const event = e.originalEvent || e
   return event.altKey || event.ctrlKey || event.metaKey || event.shiftKey
 }
+
+/**
+ * @param {MouseEvent} e
+ * @returns {boolean}
+ */
+export const isPureLMBClick = (e) => {
+  const event = e.originalEvent || e
+  return event.button === 0 && !isAlternativeClick(e)
+}