This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Always close the acid state DB #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
force-pushed
the
pr/acid-state-close
branch
from
00b84db to
827ee8b
Compare
And don't bother updating the archive on shutdown. It's of no great benefit to do each time. We should also consider whether creating the checkpoint is also always needed. If it's slow we might want to not bother, since we have to shutdown promptly or the process gets killed anyway. It's only for exchanges and ease of migration that we write the checkpoint and we can perhaps distinguish that use case.
dcoutts
force-pushed
the
pr/acid-state-close
branch
from
827ee8b to
c7dc095
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While investigating potential causes for slow shutdown of the node I noticed that we are writing checkpoints and doing archiving, but not actually closing the acid state db.
Comments
It's of no great benefit to do the archive stuff each time. The archive cleanup gets run by the worker periodicically.
We should also consider whether creating the checkpoint is also always needed on shutdown. If it's slow we might want to not bother, since we have to shutdown promptly or the process gets killed anyway. It's only for exchanges and ease of migration that we write the checkpoint and we can perhaps distinguish that use case. For example we could do a checkpoint on SIGUSR1 or SIGHUP.