Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding group rename functions #376

Merged
merged 2 commits into from
Jan 16, 2025
Merged

adding group rename functions #376

merged 2 commits into from
Jan 16, 2025

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #344


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Optional Reverse Dependency Checks:

  • Install checked with pak::pak("Genentech/checked") or pak::pak("checked")

  • Check dev versions of cardx, gtsummary, and tfrmt which are in the ddsjoberg R Universe

    Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', repos = c('https://ddsjoberg.r-universe.dev', 'https://cloud.r-project.org'))"
  • Check CRAN reverse dependencies but run tests skipped on CRAN

    Rscript -e "options(checked.check_envvars = c(NOT_CRAN = TRUE)); checked::check_rev_deps(path = '.', repos = 'https://cloud.r-project.org')"
  • Check CRAN reverse dependencies in a CRAN-like environment

    Rscript -e "options(checked.check_envvars = c(NOT_CRAN = FALSE), checked.check_build_args = '--as-cran'); checked::check_rev_deps(path = '.', repos = 'https://cloud.r-project.org')"

@ddsjoberg ddsjoberg requested a review from edelarua January 15, 2025 23:20
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Unit Tests Summary

  1 files  183 suites   53s ⏱️
180 tests 180 ✅ 0 💤 0 ❌
440 runs  440 ✅ 0 💤 0 ❌

Results for commit 991b4fd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
rename_ard_groups 👶 $+0.00$ $+2$ $0$ $0$ $0$
shift_ard_columns 💔 $0.54$ $+1.05$ $+5$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_calculated_row 💔 $0.19$ $+1.15$ add_calculated_row_x_
ard_continuous 💚 $4.19$ $-3.72$ ard_continuous_works
ard_hierarchical 💔 $8.16$ $+1.47$ ard_hierarchical_works_without_by_variables
ard_strata 💔 $0.84$ $+2.20$ ard_strata_works
rename_ard_groups 👶 $+0.00$ rename_ard_groups_reverse_
rename_ard_groups 👶 $+1.00$ rename_ard_groups_shift_
rename_ard_groups 👶 $+0.00$ rename_ard_groups_shift_messaging
shift_ard_columns 💔 $0.54$ $+1.05$ rename_ard_columns_works

Results for commit 3e157a2

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!! :)

@ddsjoberg
Copy link
Collaborator Author

Thank you @edelarua !!!

@ddsjoberg ddsjoberg merged commit fb7dba3 into main Jan 16, 2025
35 checks passed
@ddsjoberg ddsjoberg deleted the 344-rename_groups branch January 16, 2025 01:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to reverse the ordering/numbering of the grouping variables?
2 participants