Update LBT14 snapshots #790

edelarua · 2024-10-24T20:31:41Z

LBT14 snapshot updates following insightsengineering/tern#1326

github-actions · 2024-10-24T20:31:55Z

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

edelarua · 2024-10-24T20:32:12Z

I have read the CLA Document and I hereby sign the CLA

edelarua · 2024-10-24T20:32:29Z

recheck

github-actions · 2024-10-24T20:44:14Z

Unit Tests Summary

1 files 58 suites 3m 14s ⏱️
291 tests 290 ✅ 1 💤 0 ❌
684 runs 675 ✅ 9 💤 0 ❌

Results for commit 9652ade.

♻️ This comment has been updated with latest results.

github-actions · 2024-10-24T20:44:30Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
aet04	💚	$11.31$	$-7.20$	$-8$	$+2$	$0$	$0$
chevron_tlg-methods	💚	$9.95$	$-2.43$	$-5$	$+14$	$0$	$0$
coxt01	💚	$1.86$	$-1.33$	$-6$	$+1$	$0$	$0$
coxt02	💚	$2.57$	$-1.91$	$-6$	$+1$	$0$	$0$
lbt14	💚	$7.98$	$-1.27$	$-4$	$+10$	$-8$	$0$
rmpt03	💚	$2.15$	$-1.11$	$-4$	$+3$	$0$	$0$
rspt01	💚	$7.90$	$-4.30$	$-12$	$+7$	$0$	$0$
ttet01	💚	$5.76$	$-2.96$	$-6$	$+4$	$0$	$0$
utils	💚	$2.36$	$-2.22$	$-61$	$+1$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
aet04	💚	$2.06$	$-1.26$	aet04_can_handle_NA_values
aet04	💚	$9.25$	$-5.93$	aet04_can_handle_some_NA_values
coxt01	💚	$1.84$	$-1.34$	coxt01_can_handle_some_NA_values
coxt02	💚	$2.55$	$-1.92$	coxt02_can_handle_some_NA_values
ttet01	💚	$1.73$	$-1.10$	ttet01_works_if_change_reference_group
utils	💀	$0.01$	$-0.01$	convert_to_month_warning_messages_as_expected
utils	💀	$0.02$	$-0.02$	convert_to_month_work_as_expected
utils	💀	$0.01$	$-0.01$	do_call_errors_as_expected
utils	💀	$0.01$	$-0.01$	do_call_work_as_expected
utils	💀	$0.00$	$-0.00$	droplevels.character_works_as_expected
utils	💀	$0.03$	$-0.03$	execute_with_args_works_as_expected
utils	💀	$0.01$	$-0.01$	expand_list_works
utils	💀	$0.01$	$-0.01$	format_date_works_as_expected_for_Date
utils	💀	$0.01$	$-0.01$	format_date_works_as_expected_for_POSIXct
utils	💀	$0.01$	$-0.01$	get_section_div_works
utils	💀	$0.90$	$-0.90$	gg_list_is_deprecated
utils	💀	$0.02$	$-0.02$	gg_theme_chevron_works_as_expected
utils	💀	$0.90$	$-0.90$	grob_list_is_deprecated
utils	💀	$0.01$	$-0.01$	lvls.character_works_as_expected
utils	💀	$0.01$	$-0.01$	lvls.default_works_as_expected
utils	💀	$0.01$	$-0.01$	lvls.factor_works_as_expected
utils	💀	$0.01$	$-0.01$	modify_character_works
utils	💀	$0.01$	$-0.01$	modify_default_args_works_as_expected
utils	💀	$0.01$	$-0.01$	quote_str_works_as_expected
utils	💀	$0.03$	$-0.03$	set_section_div_works

Results for commit 8924f92

♻️ This comment has been updated with latest results.

clarkliming

I think the current version is corret, using n as denominator. But I would like also include @tianfang1121 to have a look

BFalquet

Please update tern version requirement in DESCRIPTION

github-actions · 2024-10-28T13:16:13Z

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      163       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       2  96.97%   128-129
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       97      12  87.63%   86, 90-94, 126-130, 133, 178
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 29       0  100.00%
R/rmpt01.R                      59       1  98.31%   132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/unwrap.R                      36       0  100.00%
R/utils.R                      178      13  92.70%   277-280, 284-287, 314, 318, 330, 332, 344
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3436      91  97.35%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +27      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1      -3  +4.43%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       +1     +11  -11.33%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +29       0  +100.00%
R/rmpt01.R                      -6     -10  +15.23%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/unwrap.R                     +36       0  +100.00%
R/utils.R                      +94     +13  -7.30%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +365     +16  -0.21%

Results for commit: 9652ade

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

tianfang1121 · 2024-10-29T05:00:39Z

I think the current version is corret, using n as denominator. But I would like also include @tianfang1121 to have a look

The way the percentage is calculated right now matches with the analysis specification in GDSR LBT14 template

clarkliming

thank you, looks good

Update LBT14 snapshots

fb1a19a

edelarua requested a review from clarkliming as a code owner October 24, 2024 20:31

edelarua mentioned this pull request Oct 24, 2024

Adds denom argument to count s_* functions insightsengineering/tern#1326

Merged

3 tasks

edelarua added the sme label Oct 24, 2024

clarkliming reviewed Oct 25, 2024

View reviewed changes

edelarua and others added 2 commits October 25, 2024 10:25

Merge branch 'main' into lbt14_snap_updates@main

24369fa

Merge branch 'main' into lbt14_snap_updates@main

7b1e0db

BFalquet reviewed Oct 28, 2024

View reviewed changes

update tern minimal version

9652ade

clarkliming approved these changes Oct 29, 2024

View reviewed changes

shajoezhu merged commit 17a84b3 into main Oct 29, 2024
29 checks passed

shajoezhu deleted the lbt14_snap_updates@main branch October 29, 2024 05:09

github-actions bot locked and limited conversation to collaborators Oct 29, 2024

shajoezhu assigned clarkliming Nov 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update LBT14 snapshots #790

Update LBT14 snapshots #790

edelarua commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 •

edited

Loading

edelarua commented Oct 24, 2024

edelarua commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

clarkliming left a comment

BFalquet left a comment

github-actions bot commented Oct 28, 2024 •

edited

Loading

tianfang1121 commented Oct 29, 2024

clarkliming left a comment

Update LBT14 snapshots #790

Update LBT14 snapshots #790

Conversation

edelarua commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 • edited Loading

edelarua commented Oct 24, 2024

edelarua commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 • edited Loading

Unit Tests Summary

github-actions bot commented Oct 24, 2024 • edited Loading

Unit Test Performance Difference

clarkliming left a comment

Choose a reason for hiding this comment

BFalquet left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 28, 2024 • edited Loading

Code Coverage Summary

Diff against main

tianfang1121 commented Oct 29, 2024

clarkliming left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading