Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

804 ttet01 fails with empty level in arm_var #805

Merged
merged 2 commits into from
Jan 9, 2025
Merged

804 ttet01 fails with empty level in arm_var #805

merged 2 commits into from
Jan 9, 2025

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Jan 9, 2025

close #804

refine the assertion in the ttet01 template and add test

thank you for the review

@BFalquet BFalquet requested a review from clarkliming as a code owner January 9, 2025 08:41
clarkliming
clarkliming approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Unit Tests Summary

  1 files   58 suites   2m 49s ⏱️
272 tests 199 ✅  73 💤 0 ❌
545 runs  356 ✅ 189 💤 0 ❌

Results for commit 8a57b55.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Unit Tests Summary

  1 files   58 suites   3m 18s ⏱️
292 tests 291 ✅ 1 💤 0 ❌
685 runs  676 ✅ 9 💤 0 ❌

Results for commit edc8a16.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ttet01 👶 $+0.02$ ttet01_returns_an_error_when_one_level_or_arm_var_is_empty

Results for commit c540fc1

♻️ This comment has been updated with latest results.

@BFalquet BFalquet merged commit 3f43376 into main Jan 9, 2025
29 checks passed
@BFalquet BFalquet deleted the 804-ttet01-fails-with-empty-level-in-arm@main branch January 9, 2025 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkliming clarkliming clarkliming approved these changes

Assignees
No one assigned
Labels
chevron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ttet01 fails with empty level in arm_var
2 participants
@BFalquet @clarkliming