-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix separator div in case of wrapping #224
Conversation
Code Coverage Summary
Diff against main
Results for commit: aac6dfb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@@ -252,6 +254,7 @@ MatrixPrintForm <- function(strings = NULL, | |||
page_titles = character(), | |||
main_footer = "", | |||
prov_footer = character(), | |||
header_section_div = NA_character_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class definition does not need this as it is not a full S4 (I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this default should not create problems in rlistings
Signed-off-by: Davide Garolini <[email protected]>
Unit Test Performance DifferenceAdditional test case details
Results for commit 7babd38 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Thanks!!
Fixes #221