-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow content row in the end #226
Conversation
Unit Tests Summary 1 files 4 suites 7s ⏱️ Results for commit 7a18413. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 7a18413 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Liming for this. I think it makes sense, and this should happen already in theory. Can you provide a couple of tests and examples for this?
Signed-off-by: Davide Garolini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me to allow. Looks good!
close #233
allow content row in the end.
for each row, if it is content row and it do not have any children, then allow it to be paginated at that position.