Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow content row in the end #226

Merged
merged 7 commits into from
Jan 4, 2024
Merged

allow content row in the end #226

merged 7 commits into from
Jan 4, 2024

Conversation

clarkliming
Copy link
Contributor

@clarkliming clarkliming commented Nov 14, 2023

close #233

allow content row in the end.

for each row, if it is content row and it do not have any children, then allow it to be paginated at that position.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Unit Tests Summary

  1 files    4 suites   7s ⏱️
 36 tests  36 ✅ 0 💤 0 ❌
242 runs  242 ✅ 0 💤 0 ❌

Results for commit 7a18413.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
R/format_value.R       194      13  93.30%   88, 104-111, 191, 210, 281, 404, 415, 423
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        469      31  93.39%   425-426, 521, 534-537, 556, 588, 682-683, 698-703, 733-736, 769-770, 802-803, 835, 907, 958, 1009, 1012, 1016
R/mpf_exporters.R      224      96  57.14%   2, 83-85, 183, 223, 228, 411, 414, 420-423, 461-635
R/page_size.R           45       1  97.78%   174
R/pagination.R         570      45  92.11%   284-287, 372-384, 453, 525, 646-647, 652, 715-716, 737-747, 1051, 1058, 1086-1093, 1239-1240, 1252-1253, 1267-1268
R/tostring.R           571      38  93.35%   29-34, 91, 143, 212, 246, 254, 290, 347-350, 443-447, 454-459, 537, 644-645, 863, 878, 973, 1025, 1066, 1111, 1166, 1173
R/utils.R                3       0  100.00%
TOTAL                 2236     238  89.36%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  -------
R/pagination.R      +10     +16  -2.72%
TOTAL               +10     +16  -0.67%

Results for commit: 7a18413

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@edelarua edelarua added the sme Tracks changes for the sme board label Nov 14, 2023
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Liming for this. I think it makes sense, and this should happen already in theory. Can you provide a couple of tests and examples for this?

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me to allow. Looks good!

@Melkiades Melkiades merged commit bebab17 into main Jan 4, 2024
23 checks passed
@Melkiades Melkiades deleted the fix_content_row_end branch January 4, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
poc sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rtables summarize_row_groups fails with export_as_txt
4 participants