Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in printing table with only one row, topleft information and column names with newlines #326

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades added bug Something isn't working sme Tracks changes for the sme board labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Tests Summary

  1 files    8 suites   16s ⏱️
 53 tests  53 ✅ 0 💤 0 ❌
370 runs  370 ✅ 0 💤 0 ❌

Results for commit 6d523aa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_inset and titles and footers word wrapping 👶 $+0.06$ matrix_form_is_prepared_correctly_for_printing_when_there_is_topleft_information_and_new_lines

Results for commit 2dfe909

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       197      12  93.91%   88, 105-112, 187, 204, 409, 423, 431
R/generics.R           125      12  90.40%   142, 280-284, 486, 498, 529, 559, 667, 680, 701-708
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        690      41  94.06%   129, 390, 510-511, 603, 613-616, 634, 665, 755-756, 770-775, 805-808, 868-869, 958-959, 986, 1014, 1066, 1228, 1264, 1267-1271, 1321, 1369, 1372, 1376
R/mpf_exporters.R      277      20  92.78%   2, 100-102, 147, 183, 227, 230, 235, 414-420, 424, 427, 431, 479, 557
R/page_size.R           42       1  97.62%   219
R/pagination.R         759      52  93.15%   327-330, 435-450, 540, 593, 598, 639, 677-688, 764, 876-877, 899-908, 1046, 1097-1098, 1249, 1286-1290, 1306, 1313, 1395, 1530-1531, 1547-1548, 1562-1563
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 658-661, 667-671, 674-677, 684-689, 772-773, 913-914, 979-986, 1036-1040, 1109, 1162, 1181-1185, 1196, 1214, 1231, 1246, 1344, 1385, 1430, 1516, 1555, 1609, 1616
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 2948     217  92.64%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/matrix_form.R       +2       0  +0.02%
TOTAL                 +2       0  +0.00%

Results for commit: 6d523aa

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @Melkiades

@Melkiades Melkiades merged commit 770ec03 into main Nov 25, 2024
29 checks passed
@Melkiades Melkiades deleted the rtables_942_error_when_one_line@main branch November 25, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: cryptic error message when printing object
3 participants