-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
289 possibility to pass custom axis
label for g_lineplot
and g_sphagettiplot
#259
Conversation
Code Coverage Summary
Diff against main
Results for commit: 2a317a3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
axis
label for g_lineplot
axis
label for g_lineplot
and g_sphagettiplot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this alternative @m7pr.
This approach will help us stay consistent with spaghettiplot.
However, I'm not seeing the same result you're getting with spaghettiplot using your example code. For me, it always shows only "AVISITCD."
This seems to happen because this line removes the label attribute:
Lines 262 to 268 in d8439aa
if (xtype == "discrete") { | |
data[[time]] <- if (!is.null(time_level)) { | |
factor(data[[time]], levels = time_level) | |
} else { | |
factor(data[[time]]) | |
} | |
} |
Could you please double check?
Ah sorry @donyunardi - I made a commit locally, but didn't push it.. Pushing it now |
Alternative to #250 , related to insightsengineering/teal.goshawk#289
Code for g_lineplot
Code for `g_sphagettiplot`
lineplot
Custom label from attribute
No attribute, so take column name
sphagettiplot
Custom label from attribute
No attribute, so take column name