Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix resolve_delayed #252

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix resolve_delayed #252

merged 3 commits into from
Dec 13, 2023

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Dec 12, 2023

@gogonzo gogonzo added the core label Dec 12, 2023
@gogonzo gogonzo linked an issue Dec 12, 2023 that may be closed by this pull request
[Bug]: Concept of delayed creates indirect dependency between data and UI elements insightsengineering/teal.transform#111
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        351     351  0.00%    172-590
R/tm_g_gh_correlationplot.R                557     557  0.00%    222-885
R/tm_g_gh_density_distribution_plot.R      275     275  0.00%    134-458
R/tm_g_gh_lineplot.R                       564     564  0.00%    160-818
R/tm_g_gh_scatterplot.R                    240     240  0.00%    142-433
R/tm_g_gh_spaghettiplot.R                  292     292  0.00%    189-547
R/toggleable_slider.R                      154     154  0.00%    82-253
R/utils-arbitrary_lines.r                  125     125  0.00%    19-175
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    25-37
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2868    2868  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6857ca1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

kartikeyakirar
kartikeyakirar approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kartikeyakirar kartikeyakirar self-assigned this Dec 12, 2023
@gogonzo gogonzo merged commit bbc456c into main Dec 13, 2023
23 checks passed
@gogonzo gogonzo deleted the 111_resolve_delayed@main branch December 13, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikeyakirar kartikeyakirar kartikeyakirar approved these changes

Assignees

@kartikeyakirar kartikeyakirar

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Concept of delayed creates indirect dependency between data and UI elements
2 participants
@gogonzo @kartikeyakirar