Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures required packages are in Imports section #774

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
+121 −168
Open

Ensures required packages are in Imports section #774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e2275ab
chore: move required packages to imports
averissimo Aug 14, 2024
4590f44
fix: ensure optional requirements in tests
averissimo Aug 14, 2024
8484c82
Merge branch 'main' into 518-pkgs_imports@main
averissimo Dec 18, 2024
a87ccd1
chore: make sure all github are included
averissimo Dec 18, 2024
3015749
chore: remove require namespaces from examples
averissimo Dec 18, 2024
b083bc4
chore: remove whitespace
averissimo Dec 18, 2024
fcedb3c
chore: remove unecessary skips
averissimo Dec 18, 2024
98ae21c
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Dec 18, 2024
27a75ad
empty: trigger ci
averissimo Dec 19, 2024
8d1c172
test: action with custom max additional repos
averissimo Dec 20, 2024
ad8ba68
Revert "test: action with custom max additional repos"
averissimo Dec 20, 2024
4a65519
Merge commit '1fd75a0376c9921b271fcd6208d6b64791470220'
llrs-roche Jan 15, 2025
7e2b01b
Recreate documentation
llrs-roche Jan 15, 2025
10139bf
Move lifecycle from Imports to Suggests
llrs-roche Jan 15, 2025
9f4b496
Fix typo
llrs-roche Jan 15, 2025
874380d
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Jan 15, 2025
749b6e3
vbump teal.reporter
m7pr Jan 15, 2025
25cfe58
update teal version
m7pr Jan 16, 2025
ff31b98
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Jan 16, 2025
f114d20
extend extra-deps with teal.slice min version
m7pr Jan 16, 2025
7f8d7cd
Merge branch '518-pkgs_imports@main' of https://github.com/insightsen…
m7pr Jan 16, 2025
7d721eb
specify SummarizedExperiment (>= 1.36.0) in extra-deps as teal.slice …
m7pr Jan 16, 2025
7526473
add MultiAssayExperiment (>= 1.32.0) to extra deps
m7pr Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/scheduled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,19 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
pair:
- { test-strategy: "min_cohort", test-additional-repos: "" }
- { test-strategy: "min_isolated", test-additional-repos: "" }
- { test-strategy: "release", test-additional-repos: "" }
- { test-strategy: "max", test-additional-repos: "https://pharmaverse.r-universe.dev" }
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
GCHAT_WEBHOOK: ${{ secrets.GCHAT_WEBHOOK }}
with:
strategy: ${{ matrix.test-strategy }}
strategy: ${{ matrix.pair.test-strategy }}
additional-repos: ${{ matrix.pair.test-additional-repos }}
additional-env-vars: |
PKG_SYSREQS_DRY_RUN=true
branch-cleanup:
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see changes in dependencies and I immediately think about verdepcheck. Can you please confirm that it is passing on this? If not - let's work on the deps versions.

This might need to wait for https://github.com/insightsengineering/teal.modules.general/pull/774/files#r1890465398

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, once min_cohort is satisfied I will try to put minimal versions of packages in the DESCRIPTION file

Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Suggests:
VignetteBuilder:
knitr,
rmarkdown
Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2,
Config/Needs/verdepcheck: tidyverse/ggplot2,
rstudio/shiny, insightsengineering/teal, insightsengineering/teal.transform,
mllg/checkmate, daattali/colourpicker, tidyverse/dplyr, rstudio/DT,
tidyverse/forcats, daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp,
Expand Down
1 change: 1 addition & 0 deletions teal.modules.general.Rproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: 003390c8-e31f-4b87-957d-7943778020cc
m7pr marked this conversation as resolved.
Show resolved Hide resolved

RestoreWorkspace: No
SaveWorkspace: No
Expand Down
Loading