Extend validate_has_data to accept vector input (#962)

Closes insightsengineering/teal.modules.general#600 --------- Signed-off-by: Vedha Viyash <[email protected]> Co-authored-by: Aleksander Chlebowski <[email protected]>
insightsengineering · Nov 20, 2023 · fcca8ec · fcca8ec
1 parent d4bab67
commit fcca8ec
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,4 @@
-# teal 0.14.0.9018
+# teal 0.14.0.9019
 
 ### New features
 

diff --git a/R/validations.R b/R/validations.R
@@ -43,10 +43,8 @@ validate_has_data <- function(x,
                               complete = FALSE,
                               allow_inf = TRUE,
                               msg = NULL) {
-  stopifnot(
-    "Please provide a character vector in msg argument of validate_has_data." = is.character(msg) || is.null(msg)
-  )
-  validate(need(!is.null(x) && is.data.frame(x), "No data left."))
+  checkmate::assert_string(msg, null.ok = TRUE)
+  checkmate::assert_data_frame(x)
   if (!is.null(min_nrow)) {
     if (complete) {
       complete_index <- stats::complete.cases(x)

diff --git a/tests/testthat/test-validate_has_data.R b/tests/testthat/test-validate_has_data.R
@@ -55,11 +55,11 @@ testthat::test_that("validate_has_data returns message msg argument is set and c
 testthat::test_that("validate_has_data returns throws error with non-character msg input", {
   testthat::expect_error(
     validate_has_data(data, 10, msg = 1),
-    "Please provide a character vector in msg argument of validate_has_data."
+    "Assertion on 'msg' failed: Must be of type 'string' \\(or 'NULL'\\), not 'double'"
   )
 
   testthat::expect_error(
     validate_has_data(data, 10, msg = TRUE),
-    "Please provide a character vector in msg argument of validate_has_data."
+    "Assertion on 'msg' failed: Must be of type 'string' \\(or 'NULL'\\), not 'logical'."
   )
 })