-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1362 module()
usage in tests/
breaks renv::snapshot
#1364
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 25 suites 8m 21s ⏱️ Results for commit b45a4f3. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: b45a4f3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Additional test case details
Results for commit 48742e0 ♻️ This comment has been updated with latest results. |
insights-engineering-bot
deleted the
1362_module_usage_breaks_renv@main
branch
January 12, 2025 03:49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run
renv::snapshot()
inteal
repository and you havemodule()
call in your tests this breaks the snapshot, for version1.0.10
ofrenv
that was published 3 days ago on CRAN. More details on #1362This PR is not meant to be merged - this is just for the demonstrational purpouses.
GitHub Action -> Scheduled -> Dependency Test - that shows
max
strategy could be fixed https://github.com/insightsengineering/teal/actions/runs/11234300369