Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teal app modifiers and deprecate init args #1440

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

[skip style] [skip vbump] Restyle files

ff480f9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Add teal app modifiers and deprecate init args #1440

[skip style] [skip vbump] Restyle files
ff480f9
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Tests Summary failed Jan 15, 2025 in 0s

11 errors, 4 fail, 4 skipped, 256 pass in 9m 49s

  1 files   27 suites   9m 49s ⏱️
275 tests 256 ✅ 4 💤 4 ❌ 11 🔥
521 runs  499 ✅ 4 💤 7 ❌ 11 🔥

Results for commit ff480f9.

Annotations

Check warning on line 0 in shinytest2_filter_panel

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 2 runs failed: e2e_filtering_a_module_specific_filter_is_not_refected_in_other_unshared_modules (shinytest2_filter_panel) 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
app$get_active_data_filters("mtcars")$cyl (`actual`) and c("4", "6") (`expected`) don't have the same values. ('test-shinytest2-filter_panel.R:98:3')
app$get_active_data_filters("mtcars")$cyl (`actual`) and c("4", "6") (`expected`) don't have the same values.
* Only in `expected`: "6"

Check warning on line 0 in shinytest2_init

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 2 runs failed: e2e_teal_app_initializes_with_sessionInfo_modal (shinytest2_init) 

teal.Rcheck/tests/testthat/junit-result.xml [took 8s]
Raw output 
app$get_text(button_selector) not equal to "Session Info". ('test-shinytest2-init.R:23:3')
app$get_text(button_selector) not equal to "Session Info".
target is NULL, current is character

Check failure on line 0 in shinytest2_init

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 2 runs with error: e2e_teal_app_initializes_with_sessionInfo_modal (shinytest2_init) 

teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-init.R:28:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal-sessionInfo-button
Backtrace:
    ▆
 1. └─app$click(selector = button_selector) at test-shinytest2-init.R:28:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check warning on line 0 in shinytest2_modules

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 2 runs failed: e2e_the_module_server_logic_is_only_triggered_when_the_teal_module_becomes_active (shinytest2_modules) 

teal.Rcheck/tests/testthat/junit-result.xml [took 0s]
Raw output 
length(test_exports) not equal to 2. ('test-shinytest2-modules.R:38:3')
length(test_exports) not equal to 2.
1/1 mismatches
[1] 1 - 2 == -1

Check failure on line 0 in shinytest2_reporter

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_reporter_tab_is_created_when_a_module_has_reporter (shinytest2_reporter) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 8s]
Raw output 
Error in `UseMethod("read_xml")`: no applicable method for 'read_xml' applied to an object of class "NULL" ('test-shinytest2-reporter.R:11:3')
Error in `UseMethod("read_xml")`: no applicable method for 'read_xml' applied to an object of class "NULL"
Backtrace:
    ▆
 1. ├─rvest::html_elements(...) at test-shinytest2-reporter.R:11:3
 2. └─app$get_html_rvest(selector = "#teal-teal_modules-active_tab")
 3.   ├─rvest::read_html(self$get_html(selector))
 4.   └─xml2:::read_html.default(self$get_html(selector))
 5.     ├─base::suppressWarnings(...)
 6.     │ └─base::withCallingHandlers(...)
 7.     └─xml2::read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options)

Check failure on line 0 in shinytest2_reporter

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_reporter_tab_is_not_created_when_a_module_has_no_reporter (shinytest2_reporter) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 8s]
Raw output 
Error in `UseMethod("read_xml")`: no applicable method for 'read_xml' applied to an object of class "NULL" ('test-shinytest2-reporter.R:30:3')
Error in `UseMethod("read_xml")`: no applicable method for 'read_xml' applied to an object of class "NULL"
Backtrace:
    ▆
 1. ├─rvest::html_elements(...) at test-shinytest2-reporter.R:30:3
 2. └─app$get_html_rvest(selector = "#teal-teal_modules-active_tab")
 3.   ├─rvest::read_html(self$get_html(selector))
 4.   └─xml2:::read_html.default(self$get_html(selector))
 5.     ├─base::suppressWarnings(...)
 6.     │ └─base::withCallingHandlers(...)
 7.     └─xml2::read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options)

Check failure on line 0 in shinytest2_reporter

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_adding_a_report_card_in_a_module_adds_it_in_the_report_previewer_tab (shinytest2_reporter) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 13s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-reporter.R:70:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal_modules-module_with_reporter-module-pcards .accordion-toggle
Backtrace:
    ▆
 1. └─app$click(selector = accordian_selector) at test-shinytest2-reporter.R:70:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check warning on line 0 in shinytest2_reporter

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

All 2 runs failed: e2e_reporter_previewer_module_do_not_show_data_summary_nor_filter_panel (shinytest2_reporter) 

teal.Rcheck/tests/testthat/junit-result.xml [took 2s]
Raw output 
app$is_visible(app$active_data_summary_element("table")) is not NULL ('test-shinytest2-reporter.R:95:3')
app$is_visible(app$active_data_summary_element("table")) is not NULL

`actual` is a logical vector (TRUE)
`expected` is NULL

Check warning on line 0 in shinytest2_reporter

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 2 runs failed: e2e_reporter_does_not_show_the_secondary_column_that_shows_filter_panel (shinytest2_reporter) 

teal.Rcheck/tests/testthat/junit-result.xml [took 2s]
Raw output 
app$is_visible(secondary_col) is not NULL ('test-shinytest2-reporter.R:136:3')
app$is_visible(secondary_col) is not NULL

`actual` is a logical vector (TRUE)
`expected` is NULL

Check failure on line 0 in shinytest2_teal_data_module

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_teal_data_module_will_have_a_delayed_load_of_datasets (shinytest2_teal_data_module) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-teal_data_module.R:33:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal-data-teal_data_module-submit.shiny-bound-input
Backtrace:
    ▆
 1. └─app$click("teal-data-teal_data_module-submit") at test-shinytest2-teal_data_module.R:33:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check failure on line 0 in shinytest2_teal_data_module

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_teal_data_module_shows_validation_errors (shinytest2_teal_data_module) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-teal_data_module.R:68:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal-data-teal_data_module-submit.shiny-bound-input
Backtrace:
    ▆
 1. └─app$click("teal-data-teal_data_module-submit") at test-shinytest2-teal_data_module.R:68:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check failure on line 0 in shinytest2_teal_data_module

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_teal_data_module_inputs_change_teal_data_object_that_is_passed_to_teal_main_UI (shinytest2_teal_data_module) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-teal_data_module.R:112:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal-data-teal_data_module-submit.shiny-bound-input
Backtrace:
    ▆
 1. └─app$click("teal-data-teal_data_module-submit") at test-shinytest2-teal_data_module.R:112:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check failure on line 0 in shinytest2_teal_data_module

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_teal_data_module_gets_removed_after_successful_data_load_when_once_TRUE (shinytest2_teal_data_module) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-teal_data_module.R:157:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal-data-teal_data_module-submit.shiny-bound-input
Backtrace:
    ▆
 1. └─app$click(submit) at test-shinytest2-teal_data_module.R:157:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check failure on line 0 in shinytest2_teal_data_module

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_teal_data_module_is_still_visible_after_successful_data_load_when_once_FALSE (shinytest2_teal_data_module) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
Error in `app_find_node_id(self, private, input = input, output = output,  ('test-shinytest2-teal_data_module.R:200:3')
Error in `app_find_node_id(self, private, input = input, output = output, 
    selector = selector)`: Cannot find HTML element with selector #teal-data-teal_data_module-submit.shiny-bound-input
Backtrace:
    ▆
 1. └─app$click("teal-data-teal_data_module-submit") at test-shinytest2-teal_data_module.R:200:3
 2.   └─super$click(...)
 3.     └─shinytest2:::app_click(...)
 4.       └─shinytest2:::app_find_node_id(self, private, input = input, output = output, selector = selector)
 5.         └─shinytest2:::app_abort(...)
 6.           └─rlang::abort(..., app = self, call = call)

Check failure on line 0 in shinytest2_teal_data_module

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

e2e_teal_data_module_will_make_other_tabs_inactive_before_successful_data_load (shinytest2_teal_data_module) with error 

teal.Rcheck/tests/testthat/junit-result.xml [took 3s]
Raw output 
Error in `UseMethod("read_xml")`: no applicable method for 'read_xml' applied to an object of class "NULL" ('test-shinytest2-teal_data_module.R:242:3')
Error in `UseMethod("read_xml")`: no applicable method for 'read_xml' applied to an object of class "NULL"
Backtrace:
     ▆
  1. ├─testthat::expect_equal(...) at test-shinytest2-teal_data_module.R:242:3
  2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
  3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
  4. ├─rvest::html_attr(...)
  5. │ └─xml2::xml_attr(x, name, default = default)
  6. ├─rvest::html_nodes(...)
  7. │ └─rvest::html_elements(...)
  8. └─app$get_html_rvest("#teal-teal_modules-active_tab")
  9.   ├─rvest::read_html(self$get_html(selector))
 10.   └─xml2:::read_html.default(self$get_html(selector))
 11.     ├─base::suppressWarnings(...)
 12.     │ └─base::withCallingHandlers(...)
 13.     └─xml2::read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options)

Check warning on line 0 in shinytest2_teal_slices

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 10 runs failed: e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created (shinytest2_teal_slices) 

teal.Rcheck/tests/testthat/junit-result.xml [took 2s]
Raw output 
names(app$get_active_data_filters("mtcars")) (`actual`) and c("drat", "gear") (`expected`) don't have the same values. ('test-shinytest2-teal_slices.R:94:3')
names(app$get_active_data_filters("mtcars")) (`actual`) and c("drat", "gear") (`expected`) don't have the same values.
* Only in `actual`: "cyl"
* Only in `expected`: "drat", "gear"

Check failure on line 0 in shinytest2_teal_slices

See this annotation in the file changed.

@github-actions github-actions / Unit Tests Summary

1 out of 10 runs with error: e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created (shinytest2_teal_slices) 

teal.Rcheck/tests/testthat/junit-result.xml [took 2s]
Raw output 
Error in `testthat::expect_setequal(app$get_active_data_filters("mtcars")$drat,  ('test-shinytest2-teal_slices.R:102:3')
Error in `testthat::expect_setequal(app$get_active_data_filters("mtcars")$drat, 
    c(3, 4))`: `object` and `expected` must both be vectors
Backtrace:
    ▆
 1. └─testthat::expect_setequal(app$get_active_data_filters("mtcars")$drat, c(3, 4)) at test-shinytest2-teal_slices.R:102:3
 2.   └─rlang::abort("`object` and `expected` must both be vectors")
View more details on GitHub Actions