Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1441 transformators documentation #1443

Merged
merged 5 commits into from
Jan 15, 2025
Merged

1441 transformators documentation #1443

merged 5 commits into from
Jan 15, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 14, 2025

Part of #1441
A reviewed documentation for transformators parameter

@m7pr m7pr added the core label Jan 14, 2025
@m7pr m7pr requested a review from llrs-roche January 14, 2025 14:01
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Tests Summary

  1 files   27 suites   10m 18s ⏱️
275 tests 271 ✅ 4 💤 0 ❌
536 runs  532 ✅ 4 💤 0 ❌

Results for commit 7890750.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $148.55$ $-1.92$ $0$ $0$ $0$ $0$

Results for commit 56094a9

♻️ This comment has been updated with latest results.

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that is better to have a verb than just repeating the name of the argument, it is still unclear to me what does it mean to transform module's data input. Is there a more specific verb? Is like decorators but the class can change? Or is it more like the teal_transform_module ? A link to its article or help page?

@m7pr
Copy link
Contributor Author

m7pr commented Jan 14, 2025

@llrs-roche transformators change input data in module. decorators change output of the module (graph or table).

@m7pr m7pr changed the title 1441 typo in documentation 1441 transformators documentation Jan 14, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 14, 2025

@llrs-roche I added a link to vignette("data-transform-as-shiny-module", package = "teal") in modules template in teal

@m7pr m7pr enabled auto-merge (squash) January 15, 2025 08:38
@m7pr m7pr merged commit d1706e6 into main Jan 15, 2025
28 checks passed
@m7pr m7pr deleted the 1441_transformators@main branch January 15, 2025 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants