Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JoinKeys related changes due to refactor #958

Merged
merged 15 commits into from
Nov 20, 2023
Merged

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Nov 6, 2023

Related to teal.data PR #184
Make changes to teal because of the refactor to the JoinKeys class from R6 to S3.

@vedhav vedhav marked this pull request as ready for review November 8, 2023 06:48
Copy link
Contributor

github-actions bot commented Nov 8, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                 92      50  45.65%   9-71
R/get_rcode_utils.R                 46       1  97.83%   49
R/include_css_js.R                  24       0  100.00%
R/init.R                            79      25  68.35%   143, 168-189, 221-223, 225-227, 229-230
R/landing_popup_module.R            25      25  0.00%    61-87
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             176      14  92.05%   72, 119, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 346-369
R/module_tabs_with_filters.R        73       2  97.26%   95, 140
R/module_teal_with_splash.R        119      11  90.76%   73, 83-91, 122
R/module_teal.R                    141       8  94.33%   68, 71, 158-159, 165, 195, 203-204
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        143      26  81.82%   119, 132, 226-229, 243-248, 259-263, 378-421
R/reporter_previewer_module.R       18       2  88.89%   26, 30
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           39       1  97.44%   158
R/teal_data_module.R                 6       0  100.00%
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R               25       0  100.00%
R/teal_slices.R                     59      12  79.66%   135-148
R/utils.R                          110      27  75.45%   113-140
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     60      37  38.33%   111-373
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1692     477  71.81%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6b3916d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Unit Tests Summary

    1 files    18 suites   12s ⏱️
195 tests 195 ✔️ 0 💤 0
369 runs  369 ✔️ 0 💤 0

Results for commit 618da39.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tdata 💀 $0.01$ $-0.01$ get_join_keys_returns_JoinKeys_object_if_it_exists_inside_tdata
tdata 💀 $0.01$ $-0.01$ get_join_keys_returns_NULL_if_no_JoinKeys_object_exists_inside_tdata
tdata 👶 $+0.01$ join_keys_returns_NULL_if_no_join_keys_object_exists_inside_tdata
tdata 👶 $+0.01$ join_keys_returns_join_keys_object_if_it_exists_inside_tdata
tdata 💀 $0.01$ $-0.01$ new_tdata_throws_error_if_join_keys_is_not_of_class_JoinKeys
tdata 👶 $+0.01$ new_tdata_throws_error_if_join_keys_is_not_of_class_join_keys
tdata 💀 $0.00$ $-0.00$ new_tdata_throws_no_error_if_join_keys_is_of_class_JoinKeys
tdata 👶 $+0.00$ new_tdata_throws_no_error_if_join_keys_is_of_class_join_keys

Results for commit 6630700

♻️ This comment has been updated with latest results.

R/init.R Outdated Show resolved Hide resolved
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vedhav vedhav merged commit 54fa9ac into main Nov 20, 2023
23 checks passed
@vedhav vedhav deleted the 78_simplify_joinkeys@main branch November 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Change JoinKeys to something simpler
4 participants