Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend validate_has_data to accept vector input #962

Merged
merged 10 commits into from
Nov 20, 2023
Merged

Extend validate_has_data to accept vector input #962

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bfa4594
feat: extend validate_has_data to accept vector input
vedhav Nov 10, 2023
cf0cc59
docs: add news and extend tests
vedhav Nov 10, 2023
2f57274
Revert "feat: extend validate_has_data to accept vector input"
vedhav Nov 16, 2023
ae8ebdd
Revert "docs: add news and extend tests"
vedhav Nov 16, 2023
d3a6860
feat: assert if `validate_has_data` gets a `data.frame`
vedhav Nov 16, 2023
f468214
Update R/validations.R
vedhav Nov 16, 2023
2b4b4c9
Update R/validations.R
vedhav Nov 20, 2023
00b2be0
Merge branch 'main' into 961-validate-vectors-too
vedhav Nov 20, 2023
f2f6896
fix: update tests with updated assertions
vedhav Nov 20, 2023
9542b13
docs: update pkg version in changelog
vedhav Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions R/validations.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ validate_has_data <- function(x,
stopifnot(
"Please provide a character vector in msg argument of validate_has_data." = is.character(msg) || is.null(msg)
)
vedhav marked this conversation as resolved.
Show resolved Hide resolved
checkmate::assert_data_frame(x)
validate(need(!is.null(x) && is.data.frame(x), "No data left."))
vedhav marked this conversation as resolved.
Show resolved Hide resolved
if (!is.null(min_nrow)) {
if (complete) {
Expand Down