471 remove CodeClass from FilteredData

[chlebowa]

Preprocessing code is no longer kept in FilteredData$code but attached to a FilteredData as an attribute.
Necessary adjustments were made in teal_data_to_filtered_data and in get_datasets_code.

companion

[github-actions]

Unit Tests Summary

    1 files    18 suites   12s ⏱️
195 tests 195 ✔️ 0 💤 0 ❌
367 runs  367 ✔️ 0 💤 0 ❌

Results for commit fda506c.

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                 92      50  45.65%   9-71
R/get_rcode_utils.R                 38       1  97.37%   50
R/include_css_js.R                  24       0  100.00%
R/init.R                            79      25  68.35%   139, 164-185, 217-219, 221-223, 225-226
R/landing_popup_module.R            25      25  0.00%    61-87
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             174      14  91.95%   72, 119, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 346-369
R/module_tabs_with_filters.R        73       2  97.26%   95, 140
R/module_teal_with_splash.R        120      11  90.83%   73, 87-95, 122
R/module_teal.R                    141       8  94.33%   68, 71, 158-159, 165, 196, 204-205
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        143      26  81.82%   119, 132, 226-229, 243-248, 259-263, 378-421
R/reporter_previewer_module.R       18       2  88.89%   26, 30
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           39       1  97.44%   158
R/teal_data_module.R                 6       0  100.00%
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R               25       0  100.00%
R/teal_slices.R                     59      12  79.66%   135-148
R/utils.R                          108      27  75.00%   113-140
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     58      37  36.21%   109-371
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1679     477  71.59%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  -------
R/get_rcode_utils.R               -8       0  -0.46%
R/module_nested_tabs.R            -2       0  -0.09%
R/module_teal_with_splash.R       +1       0  +0.08%
R/utils.R                         -2       0  -0.45%
TOTAL                            -11       0  -0.18%

Results for commit: fda506c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[gogonzo]

Please avoid taking anything except get_call and get_data from FilteredData - please take metadata directly from the data attribute

Suggested change

	metadata <- sapply(datanames, datasets$get_metadata, simplify = FALSE)
	metadata <- sapply(
	datanames,
	function(x) attr(datasets$get_data(x, filtered = TRUE)), "metadata")
	simplify = FALSE
	)

[chlebowa]

It is a public method, though 🤔

There is a get_metadata function in teal with tdata and default methods. Perhaps we should use that?

[chlebowa]

Oh, one more thing. On main this function looks like this:

.datasets_to_data <- function(module, datasets) {
  checkmate::assert_class(module, "teal_module")
  checkmate::assert_class(datasets, "FilteredData")

  datanames <- if (is.null(module$datanames) || identical(module$datanames, "all")) {
    datasets$datanames()
  } else {
    unique(module$datanames) # todo: include parents! unique shouldn't be needed here!
  }

  # list of reactive filtered data
  data <- sapply(datanames, function(x) datasets$get_data(x, filtered = TRUE), simplify = FALSE)

  hashes <- calculate_hashes(datanames, datasets)

  code <- c(
    get_rcode_str_install(),
    get_rcode_libraries(),
    get_datasets_code(datanames, datasets, hashes),
    teal.slice::get_filter_expr(datasets, datanames)
  )

  do.call(
    teal.data::teal_data,
    args = c(data, code = list(code), join_keys = list(datasets$get_join_keys()[datanames]))
  )
}

No metadata handling at all.

[chlebowa]

Maybe this just is a merge artefact?

[gogonzo]

No metadata handling at all.

You copied the function not from main. On main .datasets_to_data looks like this:

teal/R/module_nested_tabs.R

Line 314 in 50bbab6

metadata <- lapply(datanames, datasets$get_metadata)

[chlebowa]

My mistake. The function above is on refactor branch.

approved by mistake