Make implementations val final. (#377)

instacart · Aug 22, 2024 · 47077f9 · 47077f9
1 parent ac33937
commit 47077f9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/formula/src/main/java/com/instacart/formula/ActionFormula.kt b/formula/src/main/java/com/instacart/formula/ActionFormula.kt
@@ -7,7 +7,7 @@ package com.instacart.formula
  */
 abstract class ActionFormula<Input : Any, Output : Any> : IFormula<Input, Output> {
     // Implements the common API used by the runtime.
-    override val implementation: Formula<Input, Output, Output> = object : Formula<Input, Output, Output>() {
+    final override val implementation: Formula<Input, Output, Output> = object : Formula<Input, Output, Output>() {
         override fun initialState(input: Input) = initialValue(input)
 
         override fun Snapshot<Input, Output>.evaluate(): Evaluation<Output> {

diff --git a/formula/src/main/java/com/instacart/formula/Formula.kt b/formula/src/main/java/com/instacart/formula/Formula.kt
@@ -14,7 +14,7 @@ package com.instacart.formula
  * listeners. When it is used to render UI, we call it a render model (Ex: ItemRenderModel).
  */
 abstract class Formula<in Input, State, out Output> : IFormula<Input, Output> {
-    override val implementation: Formula<Input, *, Output>
+    final override val implementation: Formula<Input, *, Output>
         get() = this
 
     /**

diff --git a/formula/src/main/java/com/instacart/formula/StatelessFormula.kt b/formula/src/main/java/com/instacart/formula/StatelessFormula.kt
@@ -13,7 +13,7 @@ package com.instacart.formula
 abstract class StatelessFormula<Input, Output> : IFormula<Input, Output> {
 
     // Implements the common API used by the runtime.
-    override val implementation = object : Formula<Input, Unit, Output>() {
+    final override val implementation = object : Formula<Input, Unit, Output>() {
         override fun initialState(input: Input) = Unit
 
         override fun Snapshot<Input, Unit>.evaluate(): Evaluation<Output> {