Increase code coverage (pt2). #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Sep 12, 2024
| @@ -76,38 +75,27 @@ internal class ChildrenManager( | |||
| ) | |||
| } | |||
|
|
|||
| if (key is IndexedKey) { | |||
There was a problem hiding this comment.
Removing this as this will never happen
Laimiux
force-pushed
the
laimonas/increase-code-coverage-pt2
branch
from
6ccdd76 to
6e2e633
Compare
JaCoCo Code Coverage 96.44% ✅
Generated by 🚫 Danger |
Laimiux
force-pushed
the
laimonas/increase-code-coverage-pt2
branch
3 times, most recently
from
24a74ed to
43329d8
Compare
Laimiux
commented
Sep 12, 2024
| @@ -12,7 +11,7 @@ internal class ChildrenManager( | |||
| private val delegate: FormulaManagerImpl<*, *, *>, | |||
| private val inspector: Inspector?, | |||
| ) { | |||
| private var children: SingleRequestMap<Any, FormulaManager<*, *>>? = null | |||
| private val children: SingleRequestMap<Any, FormulaManager<*, *>> = LinkedHashMap() | |||
There was a problem hiding this comment.
No need to optimize children map initialization as FormulaManager optimizes this already
Laimiux
commented
Sep 12, 2024
| fun <Input, State, Event> initOrFindListener(key: Any, useIndex: Boolean): ListenerImpl<Input, State, Event> { | ||
| val currentHolder = listenerHolder<Input, State, Event>(key) | ||
| return if (currentHolder.requested && useIndex) { | ||
| if (key is IndexedKey) { |
There was a problem hiding this comment.
This won't happen so no need to check
Laimiux
force-pushed
the
laimonas/increase-code-coverage-pt2
branch
from
43329d8 to
fdd87cf
Compare
deesonpatel
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.