Fix mingw build

[cielavenir]

• After c183961 , make -f Makefile.unx programs/igzip arch=mingw host_cpu=x86_64 fails without b886279 .
• Even then, make -f Makefile.unx programs/igzip arch=mingw host_cpu=base_aliases CC=i686-w64-mingw32-gcc fails, which is fixed by 13272ef .

[cielavenir]

@pablodelara should I add mingw CI? (Adding macos-14 was easy as I used macos-13 template, but...)

[cielavenir]

@pablodelara added mingw CI. previously there were no Windows CI, so good?

[cielavenir]

@pablodelara could you merge this?

[pablodelara]

@pablodelara could you merge this?

Could you rebase on top of latest "master" branch? So only your commit show up.

[cielavenir]

@pablodelara rebased.

[pablodelara]

Thanks @cielavenir. Looks like there are some errors in the test log, could you take a look at them? Thanks!

[cielavenir]

@pablodelara Now I need to discuss one thing.

https://github.com/intel/isa-l/blob/master/make.inc#L203

have_threads ?= $(shell printf "int main(void){return 0;}\n" | $(CC) -x c - -o /dev/null -lpthread && echo y )

Running this code on mingw is incorrect. However, although isa-l can be built on mingw, saying that mingw is unsupported only due to this line is quite wasteful (もったいない) for me.

How this can be improved?

---

If I should make a separate issue, please tell so.

[pablodelara]

Could you add a new commit commenting out that line to see if that solves all issues? Thanks!

[cielavenir]

@pablodelara could you check current workflow result again?

[pablodelara]

@pablodelara could you check current workflow result again?

I did and there were some errors that were not actually flagged by the Github runner job, like this one:
make: *** [make.inc:236: erasure_code_perf.run] Error -1073740940

This was another issue that has been fixed already, but actually we should improve the check for exit codes in CI (I left a comment).
Many thanks for the time you are taking to improve/fix this.

[pablodelara]

Can you add "|| exit /b 1" at the end of these command lines? The same way it is done in the current ci.yml on the windows build (run_tests_windows)

[pablodelara]

Hey @cielavenir, did you try adding this?

[cielavenir]

@pablodelara with shell: bash, intermediate error will halt the entire script

[cielavenir]

cf https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell

[pablodelara]

thanks for looking into this, @cielavenir, Much appreciated!

[cielavenir]

@pablodelara actually what I need instead is to force bash (msys)

done

[pablodelara]

This is merged now, thanks for the work!