Fixes to get 2022 FAIR TREATMENT demo working #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until I can figure out what is going on, supply this properties file to keep docker-intermine-gradle happy
Until I can figure out what is going on, supply this tar file to keep docker-intermine-gradle happy
Use the one from biotestmine until I can work out what it is supposed to do
Actually I think this was getting substituted by the build.sh script so probably makes no difference.
I was getting 'Some skeletons were not replaced by real objects' and the problematic IDs were those of DataSources. I don't really understand this properly. Maybe the sources just have to be unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I had to change in order to get the 2022 FAIR TREATMENT demo working. See also intermine/docker-intermine-gradle#17
In summary I've added some missing files, including the synthetic data and implemented the workaround described in intermine/intermine#2162 (comment)
I've added a GitHub workflow to test it all.
We'll be picking this up again with the CADRE project but most likely with a new mine.