Trevor Community Contribution #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will put this on the github.md file instead |
brownsarahm
requested changes
Oct 25, 2023
faq/github.md
Outdated
| @@ -199,3 +199,18 @@ If you have trouble, create an issue and tag `@@rhodyprog4ds/fall20instructors` | |||
| ```` | |||
| Doing each new assignment in its own branch is best practice. In a typical software development flow once the codebase is stable a new branch would be created for each new feature or patch. This analogy should help you build intuition for this GitHub flow and using branches. Also, pull requests are the best way for us to give you feedback. Also, if you create a branch when you do not need it, you can easily merge them after you are done, but it is hard to isolate things onto a branch if it's on main already. | |||
| ```` | |||
|
|
|||
| ## Why won't my experience badge workflow contain the new changes after I edit the workflow? | |||
There was a problem hiding this comment.
Suggested change
| ## Why won't my experience badge workflow contain the new changes after I edit the workflow? | |
| ## Why did my workflow not run correctly? |
faq/github.md
Outdated
|
|
||
| ## Why won't my experience badge workflow contain the new changes after I edit the workflow? | ||
| ```{toggle} | ||
| If you find that a workflow you may have made changes to are not properly reflecting your workflow changes is because you may not be running the workflow correctly. |
There was a problem hiding this comment.
Suggested change
| If you find that a workflow you may have made changes to are not properly reflecting your workflow changes is because you may not be running the workflow correctly. | |
| If you find that changes you made to a workflow are not taking effect, or you run a workflow and it seems to not work, you may not be running the workflow correctly. |
brownsarahm
reviewed
Oct 26, 2023
|
I'm not completely familiar with batch options and I figured I could just copy and paste most of the changes into the clone I had open on vscode |
|
Actually completely ignore @brownsarahm. I was viewing the GitHub phone app before I even thought to check this PR to see the "add suggestion to batch option". I just saw it now looking over the PR and I will be sure to avoid making that mistake in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is where you wanted my faq addition. If not I can make a new file or whichever you think is the best option.