Support %-encoded characters in DID URL #1496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UMR1352
added
Bug
wulfraem
requested changes
Jan 13, 2025
identity_did/src/did_url.rs
Outdated
| pub(crate) fn is_valid_percent_encoded_char(s: &str) -> bool { | ||
| let mut chars = s.chars(); | ||
| let Some('%') = chars.next() else { return false }; | ||
| chars.take(2).all(|c| c.is_ascii_hexdigit() && !c.is_ascii_lowercase()) |
There was a problem hiding this comment.
I think, we should check the length of chars.take(2), as this would return an iterator with a length of 0 or 1, making wrongly percent encoded elements at the end of an input valid, e.g. relative_url.set_path(Some("/p%A")) or relative_url.set_path(Some("/p%")).
Creates an iterator that yields the first n elements, or fewer if the underlying iterator ends sooner.
(from docs)
wulfraem
reviewed
Jan 14, 2025
Co-authored-by: wulfraem <[email protected]>
wulfraem
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allow the use of %-encoded characters in DID URLs.
Links to any relevant issues
Closes #1492
Type of change
How the change has been tested
Updated unit tests.