Skip to content
Build

Implementing validator INX plugin #6

Sign in to view logs

Implementing validator INX plugin

Implementing validator INX plugin #6

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / golangci failed Oct 20, 2023 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (6)

components/validator/issuer.go|128 col 2| commentFormatting: put a space between // and comment text (gocritic)
components/validator/issuer.go|174 col 1| commentFormatting: put a space between // and comment text (gocritic)
components/validator/issuer.go|14 col 59| Comment should end in a period (godot)
components/validator/issuer.go|173| components/validator/issuer.go:173: Line contains TODO/BUG/FIXME: "TODO: should this be part of the node ma..." (godox)
components/validator/issuer.go|84 col 50| ineffectual assignment to err (ineffassign)
components/validator/issuer.go|125 col 2| SA4006: this value of err is never used (staticcheck)

Filtered Findings (0)

Annotations

Check failure on line 128 in components/validator/issuer.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/validator/issuer.go#L128 

commentFormatting: put a space between `//` and comment text (gocritic)
Raw output 
components/validator/issuer.go:128:2: commentFormatting: put a space between `//` and comment text (gocritic)
	//if err != nil && ierrors.Is(err, ErrBlockTooRecent) {
	^

Check failure on line 174 in components/validator/issuer.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/validator/issuer.go#L174 

commentFormatting: put a space between `//` and comment text (gocritic)
Raw output 
components/validator/issuer.go:174:1: commentFormatting: put a space between `//` and comment text (gocritic)
//func reviveChain(ctx context.Context, issuingTime time.Time) (*iotago.Commitment, iotago.BlockID, error) {
^

Check failure on line 14 in components/validator/issuer.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/validator/issuer.go#L14 

Comment should end in a period (godot)
Raw output 
components/validator/issuer.go:14:59: Comment should end in a period (godot)
// TODO: rename this method as it's more general than that
                                                          ^

Check failure on line 173 in components/validator/issuer.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/validator/issuer.go#L173 

components/validator/issuer.go:173: Line contains TODO/BUG/FIXME: "TODO: should this be part of the node ma..." (godox)
Raw output 
components/validator/issuer.go:173: components/validator/issuer.go:173: Line contains TODO/BUG/FIXME: "TODO: should this be part of the node ma..." (godox)
// TODO: should this be part of the node maybe?

Check failure on line 84 in components/validator/issuer.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/validator/issuer.go#L84 

ineffectual assignment to err (ineffassign)
Raw output 
components/validator/issuer.go:84:50: ineffectual assignment to err (ineffassign)
	strongParents, weakParents, shallowLikeParents, err := deps.NodeBridge.RequestTips(ctx, iotago.BlockMaxParents)
	                                                ^

Check failure on line 125 in components/validator/issuer.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/validator/issuer.go#L125 

SA4006: this value of `err` is never used (staticcheck)
Raw output 
components/validator/issuer.go:125:2: SA4006: this value of `err` is never used (staticcheck)
	strongParents, weakParents, shallowLikeParents, err := deps.NodeBridge.RequestTips(ctx, iotago.BlockTypeValidationMaxParents)
	^
View more details on GitHub Actions