overflow check

pkg/util/blockutil/block_time_calculator.go

@@ -2,6 +2,7 @@ package blockutil
 
 import (
 	"errors"
+	"math"
 	"time"
 )
 
@@ -47,9 +48,14 @@ func (btc *BlockTimeCalculator) CalculateBlockTime(height uint64) (time.Time, er
 	}
 
 	// predict block time according to tip block time and interval
+	blockInterval := btc.getBlockInterval(tipHeight)
+	blockNumer := time.Duration(height - tipHeight)
+	if blockNumer > math.MaxInt64/blockInterval {
+		return time.Time{}, errors.New("height overflow")
+	}
 	tipBlockTime, err := btc.getHistoryBlockTime(tipHeight)
 	if err != nil {
 		return time.Time{}, err
 	}
-	return tipBlockTime.Add(time.Duration(height-tipHeight) * btc.getBlockInterval(tipHeight)), nil
+	return tipBlockTime.Add(blockNumer * blockInterval), nil
 }

pkg/util/blockutil/block_time_calculator_test.go

@@ -30,16 +30,23 @@ func TestBlockTimeCalculator_CalculateBlockTime(t *testing.T) {
 		name   string
 		height uint64
 		want   time.Time
+		errMsg string
 	}{
-		{"height is in the past", tipHeight - 1, historyWrapper(tipHeight - 1)},
-		{"height is in the past I", tipHeight, historyWrapper(tipHeight)},
-		{"height is in the future", tipHeight + 1, historyWrapper(tipHeight).Add(interval)},
-		{"height is in the future I", tipHeight + 2, historyWrapper(tipHeight).Add(2 * interval)},
+		{"height is in the past", tipHeight - 1, historyWrapper(tipHeight - 1), ""},
+		{"height is in the past I", tipHeight, historyWrapper(tipHeight), ""},
+		{"height is in the future", tipHeight + 1, historyWrapper(tipHeight).Add(interval), ""},
+		{"height is in the future I", tipHeight + 2, historyWrapper(tipHeight).Add(2 * interval), ""},
+		{"height is not overflow", tipHeight + (1<<63-1)/uint64(interval), historyWrapper(tipHeight).Add((1<<63 - 1) / interval * interval), ""},
+		{"height is overflow", tipHeight + (1<<63-1)/uint64(interval) + 1, time.Time{}, "height overflow"},
 	}
 
 	for _, c := range cases {
 		t.Run(c.name, func(t *testing.T) {
 			got, err := btc.CalculateBlockTime(c.height)
+			if c.errMsg != "" {
+				r.ErrorContains(err, c.errMsg)
+				return
+			}
 			r.NoError(err)
 			r.Equal(c.want, got)
 		})