[factory] implement versioned stateDB to support archive mode #4520
+240
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
dustinxie
commented
Dec 11, 2024
| sdb.daoVersioned = daoVersioned | ||
| } else { | ||
| sdb.dao = dao | ||
| } |
There was a problem hiding this comment.
or we can add a new struct/file to implement statedb for archive-mode, like
struct stateDBArchive {
*stateDB
xxx
}
but after checking, that would entail duplicating almost all the codes, and in the future, any changes would need to go to 2 files. Let me know if you have good suggestion.
CoderZhi
reviewed
Dec 13, 2024
| return nil, ErrEmptyDBPath | ||
| } | ||
| cfg.DbPath = dbPath | ||
| return NewKVStoreWithVersion(cfg, VersionedNamespaceOption(vns...)), nil |
state/factory/statedb.go
Outdated
| @@ -111,23 +131,30 @@ func NewStateDB(cfg Config, dao db.KVStore, opts ...StateDBOption) (Factory, err | |||
| return &sdb, nil | |||
| } | |||
|
|
|||
| func (sdb *stateDB) DAO(height uint64) db.KVStore { | |||
There was a problem hiding this comment.
why is this a public function?
state/factory/statedb.go
Outdated
| if err != nil { | ||
| return 0, errors.Wrap(err, "failed to get factory's height from underlying DB") | ||
| } | ||
| return byteutil.BytesToUint64(height), nil | ||
| } | ||
|
|
||
| func (sdb *stateDB) putHeight(h uint64) error { | ||
| return sdb.DAO(h).Put(sdb.metadataNS(), []byte(CurrentHeightKey), byteutil.Uint64ToBytes(h)) |
There was a problem hiding this comment.
getHeight from dao(0) but putHeight into dao(h) is misleading and confusing
state/factory/statedb.go
Outdated
| @@ -158,24 +185,46 @@ func (sdb *stateDB) Stop(ctx context.Context) error { | |||
| sdb.mutex.Lock() | |||
| defer sdb.mutex.Unlock() | |||
| sdb.workingsets.Clear() | |||
| return sdb.dao.Stop(ctx) | |||
| return sdb.DAO(0).Stop(ctx) | |||
There was a problem hiding this comment.
stop only dao(0) is also hard to read
dustinxie
force-pushed
the
verstatedb
branch
from
ac0fbeb to
1c93d4f
Compare
dustinxie
force-pushed
the
verstatedb
branch
from
1c93d4f to
b49bdc5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as title.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: